| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, surya poondla <suryapoondla4(at)gmail(dot)com>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication |
| Date: | 2026-04-03 08:51:00 |
| Message-ID: | CAJpy0uBBNr7O_ueO3rSO5K6LaL7HhL=mDDM-qgxKR9KwZYBFkQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 3, 2026 at 9:46 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Apr 2, 2026 at 3:55 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> >
> > Hi Shveta,
> >
> > On Wed, Apr 1, 2026 at 12:06 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > >
> > > On Thu, Mar 26, 2026 at 5:23 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> > > >
> > > >
> > > > PFA patch addressing all the comments above and let me know for any
> > > > further comments.
> > > >
> > >
> > > Thank You Ashutosh. Doc looks good to me. Few comments:
> > >
> > > 3)
> > > What is the execution time for this new test?
> > > I ran it on my VM (which is slightly on the slower side), and the
> > > runtime varies between ~60 seconds and ~140 seconds. I executed it
> > > around 10–15 times. Most runs completed in about 65 seconds (which is
> > > still more), but a few were significantly longer (100+ seconds).
> > > During the longer runs, I noticed the following entry in pub.log
> > > (possibly related to Test Scenario E taking more time?). Could you
> > > please try running this on your end as well?
> > >
> > > 2026-03-31 19:45:45.557 IST client backend[145705]
> > > 053_synchronized_standby_slots_quorum.pl LOG: statement: SELECT
> > > active_pid IS NOT NULL
> > > AND restart_lsn IS NOT NULL
> > > AND restart_lsn < '0/03000450'::pg_lsn
> > > FROM pg_replication_slots
> > > WHERE slot_name = 'sb1_slot';
> > >
> > > Just for reference, the complete failover test
> > > (t/040_standby_failover_slots_sync.pl) takes somewhere between 7 to
> > > 10sec on my VM.
> > >
> >
> > My concern with this new test is that it's both slow to run and prone
> > to flakiness, which makes me question whether it's worth keeping.
> >
>
> will review and share my thoughts.
>
I gave it more thought, another idea for a shorter and quicker
testcase could be to check wait_event for that particular
application_name in pg_stat_activity. A lagging standby will result in
wait_event=WaitForStandbyConfirmation with backend_type=walsender.
I have attached sample-code to do the same in the attached txt file,
please have a look. I discussed with Hou-San offline, he is okay with
this idea. Please see if it works and change it as needed.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| wait_event.txt | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-04-03 08:57:36 | Re: Eliminating SPI / SQL from some RI triggers - take 3 |
| Previous Message | John Naylor | 2026-04-03 08:22:59 | Re: vectorized CRC on ARM64 |