| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: [bug fix] prepared transaction might be lost when max_prepared_transactions is zero on the subscriber |
| Date: | 2024-08-20 08:30:53 |
| Message-ID: | CAJpy0uA+yBtU0kUKpioy9hvUXriEnnz871zP1dirK5ba2x7V4w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 20, 2024 at 11:36 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Aug 14, 2024 at 10:26 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > >
> > > Thanks for the detailed analysis. I agree with your analysis that we
> > > need to reset the origin information for the shutdown path to avoid it
> > > being advanced incorrectly. However, the patch doesn't have sufficient
> > > comments to explain why we need to reset it for both the ERROR and
> > > Shutdown paths. Can we improve the comments in the patch?
> > >
> > > Also, for the ERROR path, can we reset the origin information in
> > > apply_error_callback()?
> >
> > Please find v4 attached. Addressed comments in that.
> >
>
> The patch looks mostly good to me. I have slightly changed a few of
> the comments in the attached. What do you think of the attached?
>
Looks good to me. Please find backported patches attached.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Don-t-advance-origin-during-apply-failure_PG17.patch | application/octet-stream | 5.7 KB |
| v1-0001-Don-t-advance-origin-during-apply-failure_PG16.patch | application/octet-stream | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-08-20 08:41:48 | Re: define PG_REPLSLOT_DIR |
| Previous Message | Jehan-Guillaume de Rorthais | 2024-08-20 08:26:51 | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |