| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-10-14 08:45:33 |
| Message-ID: | CAJcOf-f860eT4mX+7UHWEgZ=sQP_ddWLdidN+yCaOjOzLo5QaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 12, 2021 at 4:00 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've attached updated patches.
>
A couple more comments for some issues that I noticed in the v16 patches:
v16-0002
doc/src/sgml/ref/alter_subscription.sgml
(1) Order of parameters that can be reset doesn't match those that can be set.
Also, it doesn't match the order specified in the documentation
updates in the v16-0003 patch.
Suggested change:
BEFORE:
+ The parameters that can be reset are: <literal>streaming</literal>,
+ <literal>binary</literal>, <literal>synchronous_commit</literal>.
AFTER:
+ The parameters that can be reset are:
<literal>synchronous_commit</literal>,
+ <literal>binary</literal>, <literal>streaming</literal>.
v16-0003
doc/src/sgml/ref/alter_subscription.sgml
(1) Documentation update says "slot_name" is a parameter that can be
reset, but this is not correct, it can't be reset.
Also, the doc update is missing "the" before "parameter".
Suggested change:
BEFORE:
+ The parameters that can be reset are: <literal>slot_name</literal>,
+ <literal>synchronous_commit</literal>, <literal>binary</literal>,
+ <literal>streaming</literal>, and following parameter:
AFTER:
+ The parameters that can be reset are:
<literal>synchronous_commit</literal>,
+ <literal>binary</literal>, <literal>streaming</literal>, and
the following
+ parameter:
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-10-14 09:00:51 | Re: a misbehavior of partition row movement (?) |
| Previous Message | wenjing zeng | 2021-10-14 08:28:53 | Re: [Proposal] Global temporary tables |