| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: row filtering for logical replication |
| Date: | 2022-01-27 01:12:05 |
| Message-ID: | CAJcOf-f0kc+4xGEgkvqNLkbJxMf8Ff0E9gTO2biHDoSJnxyziA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 26, 2022 at 2:08 PM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> There was a miss in the posted patch which didn't initialize the parameter in
> RelationBuildPublicationDesc, sorry for that. Attach the correct patch this time.
>
I have some additional doc update suggestions for the v71-0001 patch:
(1) Patch commit comment
BEFORE:
row filter evaluates to NULL, it returns false. The WHERE clause only
AFTER:
row filter evaluates to NULL, it is regarded as "false". The WHERE clause only
doc/src/sgml/catalogs.sgml
(2) ALTER PUBLICATION
BEFORE:
+ <replaceable class="parameter">expression</replaceable> returns
false or null will
AFTER:
+ <replaceable class="parameter">expression</replaceable>
evaluates to false or null will
doc/src/sgml/ref/alter_subscription.sgml
(3) ALTER SUBSCRIPTION
BEFORE:
+ filter <literal>WHERE</literal> clause had been modified.
AFTER:
+ filter <literal>WHERE</literal> clause has since been modified.
doc/src/sgml/ref/create_publication.sgml
(4) CREATE PUBLICATION
BEFORE:
+ which the <replaceable class="parameter">expression</replaceable> returns
+ false or null will not be published. Note that parentheses are required
AFTER:
+ which the <replaceable
class="parameter">expression</replaceable> evaluates
+ to false or null will not be published. Note that parentheses
are required
doc/src/sgml/ref/create_subscription.sgml
(5) CREATE SUBSCRIPTION
BEFORE:
+ returns false or null will not be published. If the subscription has several
AFTER:
+ evaluates to false or null will not be published. If the
subscription has several
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-01-27 01:25:14 | Re: Two noncritical bugs of pg_waldump |
| Previous Message | Kyotaro Horiguchi | 2022-01-27 01:07:38 | Two noncritical bugs of pg_waldump |