| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2020-12-11 11:00:47 |
| Message-ID: | CAJcOf-dF9ohqub_D805k57Y_AuDLeAQfvtaax9SpwjTSEVdiXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Posting an updated set of patches to address recent feedback:
- Removed conditional-locking code used in parallel-safety checking
code (Tsunakawa-san feedback). It turns out that for the problem test
case, no parallel-safety checking should be occurring that locks
relations because those inserts are specifying VALUES, not an
underlying SELECT, so the parallel-safety checking code was updated to
bail out early if no underlying SELECT is specified for the INSERT. No
change to the test code was required.
- Added comment to better explain the reason for treating "INSERT ...
ON CONFLICT ... DO UPDATE" as parallel-unsafe (Dilip)
- Added assertion to heap_prepare_insert() (Amit)
- Updated error handling for NULL index_expr_item case (Vignesh)
Regards,
Greg Nancarrow
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch | application/octet-stream | 21.1 KB |
| v11-0004-Parallel-INSERT-and-or-SELECT-for-INSERT-INTO-tests-and-doc.patch | application/octet-stream | 19.4 KB |
| v11-0003-Enable-parallel-INSERT-and-or-SELECT-for-INSERT-INTO.patch | application/octet-stream | 39.1 KB |
| v11-0002-Parallel-SELECT-for-INSERT-INTO-.-SELECT-tests-and-doc.patch | application/octet-stream | 56.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2020-12-11 12:24:29 | RE: WIP: WAL prefetch (another approach) |
| Previous Message | Bharath Rupireddy | 2020-12-11 10:16:45 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |