| From: | John Naylor <jcnaylor(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: inconsistency and inefficiency in setup_conversion() |
| Date: | 2018-05-19 06:41:10 |
| Message-ID: | CAJVSVGXE8+Wq_SHZ5KJF+6t=pHJf=ySO645aBomw-nSCxhBx0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/19/18, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Looks good on Windows[1] but now it's broken on Linux[2] (also
> reproducible on my macOS laptop):
That's what happens when I squeeze in a small Makefile change without
testing the build. Fix attached. Thanks again and sorry for the noise.
(In case I didn't mention previously, the Perl script is for
visibility; reviewers/committers don't need to run it.)
-John Naylor
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-pg_language-lookup.patch | text/x-patch | 26.4 KB |
| v3-0002-Replace-ad-hoc-format-for-conversion-functions.patch | text/x-patch | 73.5 KB |
| v3-convert_conversion2dat.pl | application/x-perl | 13.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2018-05-19 07:23:43 | FindDefinedSymbol() is subtly broken |
| Previous Message | Thomas Munro | 2018-05-19 06:12:52 | Re: Postgres, fsync, and OSs (specifically linux) |