| From: | John Naylor <jcnaylor(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Avoid creation of the free space map for small tables |
| Date: | 2018-12-12 21:48:22 |
| Message-ID: | CAJVSVGVtf+-2sQGVyEZJQh15dpVicpFA6BBiPLugaD4oBEaiHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/24/18, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> 4. You have mentioned above that "system catalogs created during
> bootstrap still have a FSM if they have any data." and I can also see
> this behavior, have you investigated this point further?
I found the cause of this. There is some special-case code in md.c to
create any file if it's opened in bootstrap mode. I removed this and a
similar special case (attached), and make check still passes. After
digging through the history, I'm guessing this has been useless code
since about 2001, when certain special catalogs were removed.
-John Naylor
| Attachment | Content-Type | Size |
|---|---|---|
| remove-bootstrap-case-md.patch | text/x-patch | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-12-12 22:45:24 | gist microvacuum doesn't appear to care about hot standby? |
| Previous Message | Adrien Nayrat | 2018-12-12 21:32:06 | Log a sample of transactions |