| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove VersionedQuery support from psql tab completion |
| Date: | 2026-07-02 19:44:24 |
| Message-ID: | CAJTYsWWAinjQ3K22H5f8Lq_k_2GsunzeHcndScs+gG-xKB3VCA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, 3 Jul 2026 at 00:21, Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
> This infrastructure was added by commit 722408bcd1 and was only ever used
> for publications and subscriptions. Since we just bumped psql's minimum
> supported version to v10, it's no longer used by anything. Furthermore, a
> quick glance indicates there's nothing else that should use it. So, IMHO
> we might as well remove it.
>
Thanks for the patch!
Doing a grep on VersionedQuery I could find one instance missing
in your patch in 010_tab_completion.pl file there's a test block
# check VersionedQuery infrastructure
check_completion(
"DROP PUBLIC\t \t\t",
qr/DROP PUBLICATION\s+some_publication /,
"check VersionedQuery");
I think the test case is fine, but the comment + label needs to be
updated or case drop if it's redundant.
Rest, LGTM.
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2026-07-02 20:04:40 | Re: proposal - queryid can be used as filter for auto_explain |
| Previous Message | Andrew Dunstan | 2026-07-02 19:41:59 | Announcing Release 21 of the PostgreSQL Buildfarm Cient |