Re: BUG #19632: RULE rewriting crashes with XX000 when RETURNING old/new references a system column

From: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, hackerzheng666(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19632: RULE rewriting crashes with XX000 when RETURNING old/new references a system column
Date: 2026-08-20 08:58:17
Message-ID: CAJTYsWUuL1cvBrameN2r-n6k8Ju8nqymJVeamaf+1FDneTxRLw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

On Thu, 20 Aug 2026 at 13:59, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
wrote:

>
> On Wed, 19 Aug 2026, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> > It seems all 19629 to 19632 bug is the same line of issue, and there
> > might be more such cases where ERRCODE is not added
> > across the tree. We can accumulate all such cases and do a single
> > commit for them.
>
> I agree that it would be better to handle all this in this commit, but
> the patch you shared in [1] seems to be missing this change (the
> commit message also only references ugs up to 31). And I think we
> should also fix the error message for the FOR PORTION[2] issue.
>

Right, I initially thought of that, but I had prepared a different patch
for this, and I was going to post, but it was quite similar to the one
you already did. However, yes we can handle it all in the same
commit.

Here's a combined patch attached with all the 4 bugs addressed.
[Please help review if I missed something, also including Fujii-san
since he was working on one of them]

Regards,
Ayush

Attachment Content-Type Size
v1-0001-Fix-internal-errors-reachable-from-SQL.patch application/octet-stream 14.3 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Ayush Tiwari 2026-08-20 09:06:41 Re: BUG #19629: pg_restore_relation_stats reports XX000 instead of proper SQLSTATE for input validation errors
Previous Message Zsolt Parragi 2026-08-20 08:29:36 Re: BUG #19632: RULE rewriting crashes with XX000 when RETURNING old/new references a system column