Re: psql :: support for \ev viewname and \sv viewname

From: Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
Cc: Jeevan Chalke <jeevan(dot)chalke(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql :: support for \ev viewname and \sv viewname
Date: 2015-07-03 18:24:19
Message-ID: CAJL5ff-B2LQPoVJtA6T_RAeZekX5BFjMA2+BASEO+_bN33OxeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

пт, 3 июля 2015 г. в 19:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> So AFAICS, \ev and \sv should just number lines straightforwardly, with
> "1" being the first line of the CREATE command text. Am I missing
> something?
>

Fixed. Now both \ev and \sv numbering lines starting with "1". New version
attached.

As I've already noticed that pg_get_viewdef() does not support full syntax
of creating or replacing views. In my opinion, psql source code isn't the
place where some formatting hacks should be. So, can you give me an idea
how to produce already formatted output supporting "WITH" statement without
breaking backward compatibility of pg_get_viewdef() internals?

Attachment Content-Type Size
psql-ev-sv-support-v6.diff application/octet-stream 22.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-03 18:57:00 Re: Fix broken Install.bat when target directory contains a space
Previous Message Andres Freund 2015-07-03 17:44:22 Re: Synch failover WAS: Support for N synchronous standby servers - take 2