Skip site navigation (1) Skip section navigation (2)

Re: Turning recovery.conf into GUCs

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Turning recovery.conf into GUCs
Date: 2013-11-16 03:38:05
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Fri, Nov 15, 2013 at 4:11 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> On 11/15/2013 06:38 AM, Jaime Casanova wrote:
>>> > Please check for compiler warnings in pg_basebackup:
>>> >
>>> > pg_basebackup.c:1109:1: warning: ‘escapeConnectionParameter’ defined but not used [-Wunused-function]
>>> > pg_basebackup.c:1168:1: warning: ‘escape_quotes’ defined but not used [-Wunused-function]
>>> >
>> those are functions that are no longer used but Josh considered they
>> could become useful before release.
>> i can put them inside #ifdef _NOT_USED_ decorations or just remove
>> them now and if/when we find some use for them re add them
> Wait, which Josh?  Not me ...

sorry, i clearly misunderstood you. attached a rebased patch with
those functions removed.

Jaime Casanova
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566         Cell: +593 987171157

Attachment: recovery_guc_v5.1.patch
Description: text/x-patch (106.3 KB)

In response to


pgsql-hackers by date

Next:From: Amit KapilaDate: 2013-11-16 04:12:40
Subject: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])
Previous:From: Andrew DunstanDate: 2013-11-16 02:21:37
Subject: Re: pre-commit triggers

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group