| From: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Declarative partitioning - another take |
| Date: | 2016-11-07 17:24:59 |
| Message-ID: | CAJGNTePfg9M9smGcWQR-WdjrnU3U5uppTwJahcD-t1pBqO1=Lw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7 November 2016 at 12:15, Jaime Casanova
<jaime(dot)casanova(at)2ndquadrant(dot)com> wrote:
> On 28 October 2016 at 02:53, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>
>> Please find attached the latest version of the patches
>
> Hi,
>
> I started to review the functionality of this patch, so i applied all
> 9 patches. After that i found this warning, which i guess is because
> it needs a cast.
>
oh! i forgot the warning
"""
partition.c: In function ‘get_qual_for_list’:
partition.c:1159:6: warning: assignment from incompatible pointer type
or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1);
^
"""
attached a list of the warnings that my compiler give me (basically
most are just variables that could be used uninitialized)
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| warnings.txt | text/plain | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-07 17:34:03 | Re: Unsafe use of relation->rd_options without checking its type |
| Previous Message | Jaime Casanova | 2016-11-07 17:15:24 | Re: Declarative partitioning - another take |