| From: | Andrew Borodin <borodin(at)octonica(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Sergey Mirvoda <sergey(at)mirvoda(dot)com> |
| Subject: | Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC] |
| Date: | 2016-07-30 11:00:12 |
| Message-ID: | CAJEAwVHDCpp=5ivz7_NAT4dG1kXG13KR6MX+spt9Q1u=j3BpVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is BRIN-compatible version of patch. Now function
PageIndexTupleOverwrite consumes tuple size as a parameter, this
behavior is coherent with PageAddItem.
Also, i had to remove asserstion that item has a storage in the loop
that adjusts line pointers. It would be great if someone could check
that place (commented Assert(ItemIdHasStorage(ii)); in
PageIndexTupleOverwrite). I suspect that there might be a case when
linp's should not be adjusted.
Best regards, Andrey Borodin, Octonica & Ural Federal University.
| Attachment | Content-Type | Size |
|---|---|---|
| PageIndexTupleOverwrite v6.patch | application/octet-stream | 8.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-07-30 11:59:44 | Re: pg_dumping extensions having sequences with 9.6beta3 |
| Previous Message | Pavel Stehule | 2016-07-30 05:18:56 | Re: [BUGS] BUG #14244: wrong suffix for pg_size_pretty() |