| From: | Andrew Borodin <borodin(at)octonica(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow GiST opcalsses without compress\decompres functions |
| Date: | 2017-05-29 09:53:37 |
| Message-ID: | CAJEAwVG2i9=EbS0kCjU=ePDNpjCWwK00_vCk0D-CM+11fmNZhg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2017-05-29 0:00 GMT+05:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> But the opclass's consistent function might expect to be always given an
> untoasted input, in which case you'd need the decompress function to fix
> that up.
In cube data is detoasted at least 4 times before going to
g_cube_internal_consistent(), including once in g_cube_consistent()
But I'll address that in another patch.
Here's new version of the patch, with:
1. Corrected docs
2. Any combination of dompress\decompress\fetch is allowed
3. (Existence of fetch) or (absence of compress) leads to IOS
The last point seems counterintuitive, but I do not see anything wrong.
Best regards, Andrey Borodin, Octonica.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Allow-uncompressed-GiST-2.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-05-29 10:00:47 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Previous Message | Jeevan Ladhe | 2017-05-29 09:52:25 | Re: Default Partition for Range |