|From:||Andrew Borodin <borodin(at)octonica(dot)com>|
|To:||Andrew Borodin <amborodin(at)acm(dot)org>|
|Cc:||Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Range Merge Join v1|
|Views:||Raw Message | Whole Thread | Download mbox|
Sorry for being late. Actually, I had several unsuccessful attempts to
find something wrong with the patch.
Here's my review.
ecs = (EquivalenceClass **) palloc(nClauses * sizeof(EquivalenceClass *));
scores = (int *) palloc(nClauses * sizeof(int));
range_ecs = palloc(nClauses * sizeof(bool));
Third assignment has no cast.
And I have few questions:
1. Are there any types, which could benefit from Range Merge and are
not covered by this patch?
2. Can Range Merge handle merge of different ranges? Like int4range()
&& int8range() ?
My perf test script from the previous message was broken, here's fixed
one in the attachment.
This patch implements feature, contains new tests and passes old
tests, is documented and spec compliant. I do not see any reason why
not mark it "Ready for committer".
Best regards, Andrey Borodin.
|Next Message||Erik Rijkers||2017-05-31 06:51:24||Re: logical replication - still unstable after all these months|
|Previous Message||Noah Misch||2017-05-31 06:44:29||Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)|