| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Compression dictionaries for JSONB |
| Date: | 2022-04-25 13:15:55 |
| Message-ID: | CAJ7c6TPvcXhqsLEcuJBV96it8Zh_YbbxJ5F2ugZFySypStaoLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Zhihong,
Many thanks for your feedback!
> For src/backend/catalog/pg_dict.c, please add license header.
Fixed.
> + elog(ERROR, "skipbytes > decoded_size - outoffset");
>
> Include the values for skipbytes, decoded_size and outoffset.
In fact, this code should never be executed, and if somehow it will
be, this information will not help us much to debug the issue. I made
corresponding changes to the error message and added the comments.
Here it the 2nd version of the patch:
- Includes changes named above
- Fixes a warning reported by cfbot
- Fixes some FIXME's
- The path includes some simple tests now
- A proper commit message was added
Please note that this is still a draft. Feedback is welcome.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Compression-dictionaries-for-JSONB.patch | application/octet-stream | 49.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-04-25 13:34:00 | Re: tweak to a few index tests to hits ambuildempty() routine. |
| Previous Message | Alvaro Herrera | 2022-04-25 13:05:59 | Re: tweak to a few index tests to hits ambuildempty() routine. |