| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] Small refactoring of inval.c and inval.h |
| Date: | 2023-11-06 10:17:12 |
| Message-ID: | CAJ7c6TPSdOpNb_iUTtcmKbOrC8zzws27vyCA-omyJ+TB0621iQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> extern void InvalidateSystemCaches(void);
> -extern void InvalidateSystemCachesExtended(bool debug_discard);
>
> Indeed, that looks a bit strange, but is there a strong need in
> removing it, as you are proposing? There is always a risk that this
> could be called by some out-of-core code. This is one of these
> things where we could break something just for the sake of breaking
> it, so there is no real benefit IMO.
Fair enough, here is the corrected patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Refactor-inval.c.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-11-06 10:26:44 | Re: Moving forward with TDE [PATCH v3] |
| Previous Message | Jehan-Guillaume de Rorthais | 2023-11-06 10:14:25 | Re: Query execution in Perl TAP tests needs work |