Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>
Subject: Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date: 2024-04-18 12:00:09
Message-ID: CAJ7c6TPD=6Zx7+xWC8y5HMeH_K6NxkKb8OkX0iy8Rs2Lk-957Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> I guess the argument against inserting an enum element at the end is
> that a switch statement on the enum value might generate a compiler
> warning if it didn't have a default clause.

Fair point. PFA the alternative version of the patch.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v2-0001-Replace-constant-3-with-NUM_MERGE_MATCH_KINDS.patch application/octet-stream 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2024-04-18 12:06:05 Re: promotion related handling in pg_sync_replication_slots()
Previous Message Sriram RK 2024-04-18 11:57:48 Re: AIX support