Re: [PATCH] Cover get_json_table_plan() with tests

From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: shihao zhong <zhong950419(at)gmail(dot)com>, solai v <solai(dot)cdac(at)gmail(dot)com>, "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Cover get_json_table_plan() with tests
Date: 2026-11-09 08:06:41
Message-ID: CAJ7c6TPCeB3qXPgd8XiXH14z2_LgzX=dz9SZY5dN8F96KqnWzw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Shihao,

> Small fix: add a third path and use both sibling joins in the plan --
> PLAN (p OUTER ((p1 UNION p2) CROSS p3)). Now UNION is added so
> region coverage goes to 100% (line stays 100%). Patch attached, test
> passes.
>
> Also, given there is no other comments, move to wait for committer

Thanks for the input. The patch needed a rebase, here is v5.

It looks like you removed the previous reviewer from the commit
message and summarized only your changes, not the changes in the
entire commit. Please don't do this. In any doubt, better leave the
commit message as is. I corrected this in v5.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v5-0001-Improve-get_json_table_plan-test-coverage.patch text/x-patch 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-11-09 08:10:17 Re: A gap in preventing bogus parameterizations in a798660ebe3
Previous Message Nazir Bilal Yavuz 2026-11-09 08:05:18 Re: ci: Follow-up CI patches