| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, Michael Paquier <michael(at)paquier(dot)xyz>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Hamid Akhtar <hamid(dot)akhtar(at)percona(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Ilya Anfimov <ilan(at)tzirechnoy(dot)com> |
| Subject: | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Date: | 2022-12-09 13:42:31 |
| Message-ID: | CAJ7c6TO=FzktkHaREwt9J0pB_OqXNiNAfbSbf3WotzEirp5TnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
> I managed to reproduce the issue locally and to fix it. UBSAN is happy
> now. PFA v49.
Maxim Orlov pointed out offlist that this cast is not needed:
```
- SimpleLruTruncate(CommitTsCtl, (int)cutoffPage);
+ SimpleLruTruncate(CommitTsCtl, cutoffPage);
```
SimpleLruTruncate() accepts cutoffPage as uint64 in 0001.
PFA the corrected patchset v50.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v50-0001-Use-64-bit-numbering-of-SLRU-pages.patch | application/octet-stream | 31.1 KB |
| v50-0003-Use-64-bit-FullTransactionId-instead-of-Epoch-xi.patch | application/octet-stream | 18.8 KB |
| v50-0002-Use-64-bit-format-to-output-XIDs.patch | application/octet-stream | 126.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-12-09 13:46:12 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | Masahiko Sawada | 2022-12-09 13:32:50 | Re: [PoC] Improve dead tuple storage for lazy vacuum |