| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rand48 replacement |
| Date: | 2021-11-22 13:57:56 |
| Message-ID: | CAJ7c6TNv7rOdQkWwVDDVQ3A8X=KbPvG_3pUZ5dctz8JDEW4FZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
>
> > I guess the declaration needs PGDLLIMPORT.
>
> Indeed, thanks!
>
> Attached v16 adds that.
It looks like the patch is in pretty good shape. I noticed that the
return value of pg_prng_strong_seed() is not checked in several
places, also there was a typo in pg_trgm.c. The corrected patch is
attached. Assuming the new version will not upset cfbot, I would call
the patch "Ready for Committer".
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| prng-17.patch | application/octet-stream | 66.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-11-22 14:02:47 | Re: Teach pg_receivewal to use lz4 compression |
| Previous Message | David Christensen | 2021-11-22 13:47:41 | Re: CREATE ROLE IF NOT EXISTS |