| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] Check more invariants during syscache initialization |
| Date: | 2023-07-26 16:01:11 |
| Message-ID: | CAJ7c6TMiGRB2BWpmgEWONzRqdO56WOtd=oNkugaieOj-RNJZHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> Shouldn't these be calling `OidIsValid(…)`, not comparing directly to
> `InvalidOid`?
They should, thanks. Here is the updated patch. I made sure there are
no others != InvalidOid checks in syscache.c and catcache.c which are
affected by my patch. I didn't change any other files since Zhang
wants to propose the corresponding patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Check-more-invariants-during-syscache-initializat.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-07-26 16:07:20 | Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan |
| Previous Message | Anthonin Bonnefoy | 2023-07-26 15:54:51 | Re: POC: Extension for adding distributed tracing - pg_tracing |