| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Define DatumGetInt8 function. |
| Date: | 2026-01-07 14:03:19 |
| Message-ID: | CAJ7c6TM4zecvHj0F9Xk-V1gKqjYQOR4EjerTVkrZ18+w-6JN3Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> Hmm, v1 looks good and self-contained to me. Like, anyway, making two
> commits (one for signed Int8 and one for unsigned) here is better for
> sake of atomicy?
> Anyway, I can see there are users of UInt8GetDatum, which are [0] and
> forks of Greenplum. So, I am not super-sure removing UInt8* is
> desirable.
Fair enough. Let it be a separate patch then.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Remove-DatumGetUInt8-and-UInt8GetDatum.patch | text/x-patch | 3.7 KB |
| v2-0001-Remove-Int8GetDatum-function.patch | text/x-patch | 875 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2026-01-07 14:06:54 | Re: [PATCH] Provide support for trailing commas |
| Previous Message | Jelte Fennema-Nio | 2026-01-07 13:54:11 | Re: New commitfest app release on August 19th |