| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Subject: | Re: rand48 replacement |
| Date: | 2021-05-24 13:08:16 |
| Message-ID: | CAJ7c6TM2qJdtehyLA79gFtZ+h7jwRrksK4ZAW7boxgQJqQkRAw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Fabien,
> To summarize:
> - better software engineering
> - similar speed (slightly slower)
> - better statistical quality
> - quite small state
> - soundness
Personally, I think your patch is great. Speaking of the speed I
believe we should consider the performance of the entire DBMS in
typical scenarios, not the performance of the single procedure. I'm
pretty sure in these terms the impact of your patch is neglectable
now, and almost certainly beneficial in the long term because of
better randomness.
While reviewing your patch I noticed that you missed
test_integerset.c. Here is an updated patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| prng-2.patch | application/x-patch | 41.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2021-05-24 13:08:57 | Re: rand48 replacement |
| Previous Message | Daniel Gustafsson | 2021-05-24 12:42:59 | Re: Commitfest app vs. pgsql-docs |