| From: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: [HACKERS] UPDATE of partition key |
| Date: | 2017-12-13 10:18:37 |
| Message-ID: | CAJ3gD9fcMOLM=1ABuRg7crA2ZPBdFnfQ4v_HkmQ6rJ-NiVSFyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1 December 2017 at 17:24, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> Attached is v28 patch which has the fix for this issue as described
> above. In ExecUpdate(), if partition constraint fails, we skip
> ExecWithCheckOptions (), and later in ExecInsert() it gets called with
> WCO_RLS_UPDATE_CHECK.
Amit Langote informed me off-list, - along with suggestions for
changes - that my patch needs a rebase. Attached is the rebased
version. I have also bumped the patch version number (now v29),
because this as additional changes, again, suggested by Amit L :
Because ExecSetupPartitionTupleRouting() has mtstate parameter now,
no need to pass update_rri and num_update_rri, since they can be
retrieved from mtstate.
Also, the preparatory patch is also rebased.
Thanks Amit Langote.
--
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company
| Attachment | Content-Type | Size |
|---|---|---|
| encapsulate_partinfo_preparatory_rebased.patch | application/octet-stream | 22.1 KB |
| update-partition-key_v29.patch | application/octet-stream | 129.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2017-12-13 11:13:01 | Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug |
| Previous Message | Tomas Vondra | 2017-12-13 10:10:46 | Re: [HACKERS] Custom compression methods |