Re: UPDATE of partition key

From: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: UPDATE of partition key
Date: 2017-09-04 05:22:16
Message-ID: CAJ3gD9daWyQmEzNz57KNrEnDhUbRQ8xC70dG0=41PRHb=Yo7Qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4 September 2017 at 07:43, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Sun, Sep 3, 2017 at 5:10 PM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
>> On 31 August 2017 at 14:15, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
>>> Thanks Dilip. I am working on rebasing the patch. Particularly, the
>>> partition walker in my patch depended on the fact that all the tables
>>> get opened (and then closed) while creating the tuple routing info.
>>> But in HEAD, now only the partitioned tables get opened. So need some
>>> changes in my patch.
>>>
>>> The partition walker related changes are going to be inapplicable once
>>> the other thread [1] commits the changes for expansion of inheritence
>>> in bound-order, but till then I would have to rebase the partition
>>> walker changes over HEAD.
>>>
>>> [1] https://www.postgresql.org/message-id/0118a1f2-84bb-19a7-b906-dec040a206f2%40lab.ntt.co.jp
>>>
>>
>> After recent commit 30833ba154, now the partitions are expanded in
>> depth-first order. It didn't seem worthwhile rebasing my partition
>> walker changes onto the latest code. So in the attached patch, I have
>> removed all the partition walker changes.
>>
>
> It seems you have forgotten to attach the patch.

Oops sorry. Now attached.

--
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company

Attachment Content-Type Size
update-partition-key_v16.patch application/octet-stream 113.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-09-04 05:26:37 Re: pg_basebackup throttling doesn't throttle as promised
Previous Message Amit Langote 2017-09-04 05:04:43 Re: dropping partitioned tables without CASCADE