Re: [Patch]Add tab completion for DELETE ... USING

From: Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [Patch]Add tab completion for DELETE ... USING
Date: 2026-03-01 06:06:40
Message-ID: CAHza6qcYN6vjpD_39RpPKBBmY4XP4Vyv-61Us8Z5A8hwgd1cGw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fujii-san,

Thank you for your review!

> Would it be better to use "relations supporting SELECT" instead of
"selectables"?

Good point. I've updated the comment to use "relations supporting SELECT"
for consistency.

> As for the regression test, I agree with Kirill.

In my earlier discussion with Kirill, I argued that tests should be kept
since this patch implements a new feature.
However, I now understand that the existing tests already cover the
Query_for_list_of_selectables pattern,
so a separate test for DELETE ... USING would be redundant. I've removed
the test in the updated patch.

I've prepared a v5 patch with the following changes:
- Use "relations supporting SELECT" in the comment for consistency
- Remove the regression test

The updated v5 patch is attached.

Regards,
Tatsuya Kawata

Attachment Content-Type Size
v5-0001-Add-tab-completion-for-DELETE-USING.patch application/octet-stream 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2026-03-01 08:40:08 Re: [BUG?] estimate_hash_bucket_stats uses wrong ndistinct for avgfreq
Previous Message Pavel Stehule 2026-03-01 05:44:17 Re: POC: PLpgSQL FOREACH IN JSON ARRAY