| From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: json api WIP patch |
| Date: | 2013-01-07 15:25:16 |
| Message-ID: | CAHyXU0xywF4M3TJL6FGMm=19mjA+9v0dGcxTDv51RzGzFa4s1Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 4, 2013 at 3:03 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> I understand - but hstore isn't in core - so it should not be precedent
>
> regexp_split_to_table
>
> I am not native speaker, it sounds little bit strange - but maybe
> because I am not native speaker :)
it's common usage: http://api.jquery.com/jQuery.each/
the patch looks fabulous. There are a few trivial whitespace issues
yet and I noticed a leaked hstore comment@ 2440:
+ /*
+ * if the input hstore is empty, we can only skip the rest if we were
+ * passed in a non-null record, since otherwise there may be issues with
+ * domain nulls.
+ */
merlin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-01-07 16:16:07 | Re: Improve compression speeds in pg_lzcompress.c |
| Previous Message | Boszormenyi Zoltan | 2013-01-07 14:23:02 | Re: Review of "pg_basebackup and pg_receivexlog to use non-blocking socket communication", was: Re: Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown |