Re: [HACKERS] logical decoding of two-phase transactions

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-03-10 12:47:23
Message-ID: CAHut+PuuKbDntXjKTHza25Vd3qFxJkvCwwd75=qjdrcF9Ja_wQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Please find attached the latest patch set v56*

Differences from v55* are:

* Rebased to HEAD @ today

* Addresses the following feedback issues:

(35) [ak-0307] Skipped. Suggestion to replace HTAB with List for
tracking what psf files to delete at proc-exit; Although the idea had
merit at the time, it turned out that the due to a separate bugfix
from colleague it was necessary that we also know the count of psf
files still yet to be replayed. This count was easy to know using the
existing HTAB entries, but the List entry would have been deleted
already at prepare time, so same could not be done easily if we
changed to List. So we will keep HTAB instead of List for now.

(44) [vc-0308] Fixed. Add CHECK_FOR_INTERRUPTS() to apply worker loop.

(51) [ak-0308] Fixed. New location for psf files "pg_logical/twophase".

(54) [vc-0309] Fixed. Change rollback test description text.

(55) [ak-0309] Fixed. Change to comment text of prepare_spoolfile_handler.

(56) [ak-0309] Fixed. Remove boolean variable from prepare_spoolfile_exists.

(57) [ak-0309] Skipped. Suggestion to pfree memory; it is already freed.

(58) [ak-0309] Fixed. Common code for found/not-found psf at *_create() time.

(59) [ak-0309] Skipped. Suggestion to use *_close() from *_replay();
not compatible with intent.

(60) [ak-0309] Fixed. General comment about PSF added top of worker.c

-----
[vc-0308] https://www.postgresql.org/message-id/CALDaNm29gOsCUtNkvHgqbbD1kbM8m67h4AqfmUWG1oTnfuPFxA%40mail.gmail.com
[vc-0309] https://www.postgresql.org/message-id/CALDaNm0QuncAis5OqtjzOxAPTZRn545JLqfjFEJwyRjUH-XvEw%40mail.gmail.com
[ak-0307] https://www.postgresql.org/message-id/CAA4eK1%2BdO07RrQwfHAK5jDP9qiXik4-MVzy%2BcoEG09shWTJFGg%40mail.gmail.com
[ak-0308] https://www.postgresql.org/message-id/CAA4eK1%2BoSUU77T92FueDJWsp%3DFjTroNaNC-K45Dgdr7f18aBFA%40mail.gmail.com
[ak-0309] https://www.postgresql.org/message-id/CAA4eK1Jra658uuT8zo1DcZLzpNvo4oeorMcCuSeyY2zvr3_KBA%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v56-0003-Support-2PC-txn-Subscription-option.patch application/octet-stream 36.4 KB
v56-0004-Fix-apply-worker-empty-prepare-dev-logs.patch application/octet-stream 12.8 KB
v56-0002-Support-2PC-txn-subscriber-tests.patch application/octet-stream 24.3 KB
v56-0001-Add-support-for-apply-at-prepare-time-to-built-i.patch application/octet-stream 67.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-03-10 12:47:51 Re: shared-memory based stats collector
Previous Message Georgios 2021-03-10 12:30:08 Re: Allow batched insert during cross-partition updates