Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis
Date: 2025-11-26 22:24:51
Message-ID: CAHut+Pu5rvsKBj2OL7oCdBgm7N5=rpJXWEA3hR37_QOyU_-ZyA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 25, 2025 at 10:47 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Nov 25, 2025, at 18:42, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Fri, Nov 21, 2025 at 3:27 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >>
> >>
> >>
> >>> On Nov 21, 2025, at 05:08, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >>>
> >>> I've reverted the ALTER 'publication_drop_object' part to be the same
> >>> as master (i.e. removed the v6 'table' replacement) after Fujii-San
> >>> showed [1] that the original synopsis style is present on some other
> >>> documentation pages.
> >>>
> >>> PSS new patch v7.
> >
> > Thanks for updating the patch! LGTM.
> >
> > One question: do we want to backpatch this? If so, to which versions?
> > If we decide to backpatch, it would be helpful if you could provide versions
> > of the patch that apply cleanly to those older branches.
> >
>
> I just checked the docs version by version, looks like the back-port can go down to 15.
>

Here are the back patches as requested. I hope they are OK.

~~~

v8-PG19devel - same as v7.

v8-PG18 - same as above, except the CREATE 'publication_all_object' is
not needed because FOR ALL SEQUENCES did not exist

v8-PG17 - same as above

v8-PG16 - same as above

v8-PG15 - same as above

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v8-0001-PG18.-Fix-synopsis.patch application/octet-stream 3.1 KB
v8-0001-PG16.-Fix-synopsis.patch application/octet-stream 3.1 KB
v8-0001-PG17.-Fix-synopsis.patch application/octet-stream 3.1 KB
v8-0001-PG15.-Fix-synopsis.patch application/octet-stream 3.1 KB
v8-0001-PG19devel.-Fix-synopsis.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-11-26 22:49:49 show size of DSAs and dshash tables in pg_dsm_registry_allocations
Previous Message David Geier 2025-11-26 22:09:31 Consistently use palloc_object() and palloc_array()