Re: create subscription - improved warning message

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: create subscription - improved warning message
Date: 2022-10-14 02:52:11
Message-ID: CAHut+Ptw46s7vwHeNbVZoe6M8UBf0=ffXyBi59kNpwm+KbrRfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 13, 2022 at 9:07 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Thu, Oct 13, 2022 at 2:01 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > On 2022-Oct-12, Amit Kapila wrote:
> > >> Okay, then I think we can commit the last error message patch of Peter
> > >> [1] as we have an agreement on the same, and then work on this as a
> > >> separate patch. What do you think?
> >
> > > No objection.
> >
> > Yeah, the v3-0001 patch is fine. I agree that the docs change needs
> > more work.
>
> Thanks to everybody for the feedback/suggestions. I will work on
> improving the documentation for this and post something in a day or
> so.

PSA a patch for adding examples of how to activate a subscription that
was originally created in a disconnected mode.

The new docs are added as part of the "Logical Replication -
Subscription" section 31.2.

The CREATE SUBSCRIPTION reference page was also updated to include
links to the new docs.

Feedback welcome.

------
Kind Regards,
Peter Smith.
Fujitsu Australia.

Attachment Content-Type Size
v4-0001-create-subscriptipon-pgdocs-for-deferred-slot-cre.patch application/octet-stream 9.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2022-10-14 02:59:28 [meson] add missing pg_attribute_aligned for MSVC in meson build
Previous Message shiy.fnst@fujitsu.com 2022-10-14 02:25:58 RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher