| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding |
| Date: | 2025-05-15 23:59:36 |
| Message-ID: | CAHut+PtUf0uL+=z=cCC-mVdkCRkxbEi5QoNG00xpGqQSo1Hj+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ajin.
One comment for the patch set v18-0003..
======
1.
+$log_location = -s $node_publisher->logfile;
+$node_publisher->safe_psql('postgres', "DELETE FROM insert_only_table
WHERE id = 1");
+$node_publisher->wait_for_catchup('sub_all');
+
+$logfile = slurp_file($node_publisher->logfile, $log_location);
+ok($logfile =~ qr/Filtering DELETE/,
+ 'unpublished DELETE is filtered');
+
For this delete filter test, shouldn't there be another log file check
missing here which names the filtered relation? -- e.g. something like
+ok($logfile =~ qr/Filtering change for relation "insert_only_table"/,
+ 'delete for relation insert_only_table is filtered');
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-05-16 01:28:28 | Re: doc: Make logical replication examples executable in bulk and legal sgml. |
| Previous Message | Matheus Alcantara | 2025-05-15 21:06:19 | Re: POC: Parallel processing of indexes in autovacuum |