| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: create subscription - improved warning message |
| Date: | 2022-10-19 04:40:31 |
| Message-ID: | CAHut+PtRuLMd8emz1N3ZTnQcciD-ru=p+mq-mPzfD2C1fHYVzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 19, 2022 at 2:44 PM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
...
>
> +test_sub=# CREATE SUBSCRIPTION sub1
> +test_sub-# CONNECTION 'host=localhost dbname=test_pub'
> +test_sub-# PUBLICATION pub1
> +test_sub-# WITH (slot_name=NONE, enabled=false, create_slot=false);
> +WARNING: subscription was created, but is not connected
> +HINT: To initiate replication, you must manually create the replication slot, enable the subscription, and refresh the subscription.
> +CREATE SUBSCRIPTION
>
> In example 3, there is actually no such warning message when creating
> subscription because "connect=false" is not specified.
>
Oh, thanks for finding and reporting that. Sorry for my cut/paste
errors. Fixed in v7. PSA,
> I have tested the examples in the patch and didn't see any problem other than
> the one above.
>
Thanks for your testing.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-create-subscription-pgdocs-for-deferred-slot-crea.patch | application/octet-stream | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-10-19 04:51:12 | Re: thinko in basic_archive.c |
| Previous Message | Yugo NAGATA | 2022-10-19 04:29:25 | Re: make_ctags: use -I option to ignore pg_node_attr macro |