| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Simplify some logical replication worker type checking |
| Date: | 2023-08-01 05:32:10 |
| Message-ID: | CAHut+Ps_b=523-o-om21xmgYu5OrcNwg7QywA16ps+oRaopivA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 1, 2023 at 12:59 PM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
>
> About 2,3,4, it seems you should use "if (am_leader_apply_worker())" instead of
> "if (!am_leader_apply_worker())" because only leader apply worker should invoke
> this function.
>
Hi Hou-san,
Thanks for your review!
Oops. Of course, you are right. My cut/paste typo was mostly confined
to the post, but there was one instance also in the patch.
Fixed in v2.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Simplify-worker-type-checks.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2023-08-01 06:23:54 | Fix pg_stat_reset_single_table_counters function |
| Previous Message | Jeff Davis | 2023-08-01 05:28:31 | Re: Faster "SET search_path" |