| From: | Catalin Iacob <iacobcatalin(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: PL/Pythonu - function ereport |
| Date: | 2015-11-05 06:24:45 |
| Message-ID: | CAHg_5gpwj8fy0sEntYKcn91-m+osq+bHpaj7pa+-KFO5M3-ZbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 4, 2015 at 10:12 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> It helped me lot of, thank you
Welcome, I learned quite some from the process as well.
>>
>>
>> There's just the doc part left then.
>
>
> done
We're almost there but not quite.
There's still a typo in the docs: excation.
A plpy.SPIError can be raised should be A
<literal>plpy.SPIError</literal> can be raised right?
And most importantly, for Python 3.5 there is a plpython_error_5.out
which is needed because of an alternative exception message in that
version. You didn't update this file, this makes the tests fail on
Python3.5.
Since you might not have Python 3.5 easily available I've attached a
patch to plpython_error_5.out which makes the tests pass, you can fold
this into your patch.
| Attachment | Content-Type | Size |
|---|---|---|
| adjust_py35_expected.patch | binary/octet-stream | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2015-11-05 06:36:38 | Note about comparation PL/SQL packages and our schema/extensions |
| Previous Message | Michael Paquier | 2015-11-05 06:00:51 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |