| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: pg_waldump and PREPARE |
| Date: | 2019-11-12 09:41:12 |
| Message-ID: | CAHGQGwHNMYv1=DGEMPAnmXtLfFJ=r2=aE8tBBTz76oMycr0bqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 12, 2019 at 6:03 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Nov 12, 2019 at 05:53:02PM +0900, Fujii Masao wrote:
> > Thanks for the review! But probably I failed to understand your point...
> > Could you clarify what actual change is necessary? You are thinking that
> > the check of "parsed.nmsgs >= 0" should be moved to the inside of
> > standby_desc_invalidations()?
>
> Yes that's what I meant here.
Ok, I changed the patch that way.
Attached is the latest version of the patch.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| prepare-xact-desc_v4.patch | application/octet-stream | 11.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mahendra Singh | 2019-11-12 09:43:55 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Dilip Kumar | 2019-11-12 09:33:26 | Re: cost based vacuum (parallel) |