| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | VASUKI M <vasukianand0119(at)gmail(dot)com> |
| Cc: | Michael Banck <mbanck(at)gmx(dot)net>, Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, melanieplageman(at)gmail(dot)com, juanjo(dot)santamaria(at)gmail(dot)com |
| Subject: | Re: [PATCH] Expose checkpoint reason to completion log messages. |
| Date: | 2026-01-06 13:25:39 |
| Message-ID: | CAHGQGwGXoai8-83p5x2FhHnu6LD=epsapa_RTTzM3RHShju3Jw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 6, 2026 at 8:09 PM VASUKI M <vasukianand0119(at)gmail(dot)com> wrote:
>
> Yeah,the proposed idea makes sense to me,as users will almost see at the end of log messages it will be easy to find out what is the checkpoint reason.
> +1 for it.
If we do this, it would be better to keep the wording consistent between
the checkpoint starting and completion messages. For example,
the patch represents CHECKPOINT_FAST as "immediate",
while the checkpoint starting message uses "fast"; those should match.
I'm also wondering why this information is currently included only in
the checkpoint starting message. I tried to find any past discussion on this,
but couldn’t find one.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavlo Golub | 2026-01-06 13:32:16 | Re[2]: [PATCH] Add pg_current_vxact_id() function to expose virtual transaction IDs |
| Previous Message | Jakub Wartak | 2026-01-06 13:23:33 | Re: failed NUMA pages inquiry status: Operation not permitted |