Re: DOCS: Describe some missing parameters on CREATE/ALTER PUBLICATION pages

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOCS: Describe some missing parameters on CREATE/ALTER PUBLICATION pages
Date: 2026-07-22 11:08:09
Message-ID: CAHGQGwG2VA0iW8S=PDn34Ytx07F0TCH0vOP9y8jtPwDO5Tn7Qw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 22, 2026 at 11:59 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Mon, May 18, 2026 at 3:42 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Ping. This patch was posted about 5 weeks ago, but has received no
> > feedback so far.
> >
>
> Ping.

Thanks for the patches!

+1 to adding the missing CREATE/ALTER PUBLICATION parameter descriptions
and anchors.

I think these patches can be committed as a single commit, so I merged them
into one patch and made a few minor cleanup changes. Barring any objections,
I'm thinking to commit it. Since this is an improvement rather than a fix,
I think it should go to master only. Thoughts?

The additional changes are:

- Fix the typo "schmema_name" to "schema_name".
- Change the new anchor IDs to use hyphens instead of underscores, to match
the naming convention used by other SQL reference parameter anchors.
- Rename sql-alterpublication-params-set-parameter to
sql-alterpublication-params-set for consistency with similar anchors,
such as those for ALTER SUBSCRIPTION.
- Change "column_name list" back to "column list", since that wording is
clearer in prose and is already used elsewhere in the docs.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v2-0001-doc-Add-missing-CREATE-ALTER-PUBLICATION-paramete.patch application/octet-stream 7.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2026-07-22 11:19:11 Re: Streaming replication and WAL archive interactions
Previous Message Amit Kapila 2026-07-22 10:46:34 Re: sequencesync worker race with REFRESH SEQUENCES