| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Standby accepts recovery_target_timeline setting? |
| Date: | 2019-10-11 07:48:22 |
| Message-ID: | CAHGQGwG-_BwOihwk725cnhkTnmiNgL0E+vrVsSqOc-iL-q+stw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 10, 2019 at 5:52 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 2019-09-30 03:48, Fujii Masao wrote:
> > Also we need to do the same thing for other recovery options like
> > restore_command. Attached is the patch which makes crash recovery
> > ignore restore_command and recovery_end_command.
>
> This patch looks correct to me.
Thanks for the review! I committed the patch.
> Do we need to handle archive_cleanup_command? Perhaps not.
No, because archive_command is basically executed by checkpointer
and this process cannot be invoked in crash recovery case.
> A check in recoveryApplyDelay() might be necessary.
Yes! We are discussing this issue at
https://www.postgresql.org/message-id/CAHGQGwEyD6HdZLfdWc+95g=VQFPR4zQL4n+yHxQgGEGjaSVheQ@mail.gmail.com
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-10-11 08:13:19 | Re: maintenance_work_mem used by Vacuum |
| Previous Message | Amit Langote | 2019-10-11 07:23:51 | Re: dropping column prevented due to inherited index |