Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.

On Wed, Jan 25, 2012 at 5:35 AM, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> On Tue, Jan 24, 2012 at 3:22 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> Add new replication mode synchronous_commit = 'write'.
>> Replication occurs only to memory on standby, not to disk,
>> so provides additional performance if user wishes to
>> reduce durability level slightly. Adds concept of multiple
>> independent sync rep queues.
>>
>> Fujii Masao and Simon Riggs
>>
>
> i guess, you should add the new value in postgresql.conf too.

Yes, I forgot to do that. Patch attached.

> just a question, why not add a flush value and make it behave like on?
> actually sync rep is on in both cases and having the different names
> makes more easy to unserstand what is happening.
> i only want to keep on for compatibility but i wouldn't mind if we
> remove it in favor of more descriptive names.

Also we should add "async" as an alias for "off"?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center