| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tristan Partin <tristan(at)partin(dot)io> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix publisher-side sequence permission reporting |
| Date: | 2026-06-19 14:15:52 |
| Message-ID: | CAHGQGwE95GLD7RZr2g=zTHKJRafKACmKouhb4TTVH155Hy8zKA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 19, 2026 at 8:11 AM Tristan Partin <tristan(at)partin(dot)io> wrote:
> The patch looks good to me! I had one suggestion:
>
> > ##########
> > # Ensure that insufficient privileges on the publisher for a sequence do not
> > -# disrupt the subscriber. The subscriber should log a warning and continue
> > -# retrying.
> > +# get misreported as a missing sequence. The subscriber should log a warning
> > +# and continue retrying.
> > ##########
>
> I think a better comment might be:
>
> Ensure that insufficient privileges on the publisher for a sequence
> are reported correctly...
>
> My reasoning for suggesting that is because your comment would to
> indicate that any warning is accurate as long as it isn't related to
> a missing sequence.
Thanks for the review! I've updated the patch as suggested.
Updated patches attached.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-doc-Clarify-pg_get_sequence_data-privileges-and-N.patch | application/octet-stream | 2.2 KB |
| v2-0001-Fix-misreporting-of-publisher-sequence-permission.patch | application/octet-stream | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-06-19 14:51:02 | Re: fix pg_mkdir_p to tolerate concurrent directory creation |
| Previous Message | Álvaro Herrera | 2026-06-19 14:01:47 | Re: fix pg_mkdir_p to tolerate concurrent directory creation |