| From: | Sehrope Sarkuni <sehrope(at)jackdb(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assorted Win32 error handling fixes (CreateThread, pgwin32_select, pg_usleep) |
| Date: | 2026-08-29 19:51:58 |
| Message-ID: | CAH7T-apQipawP3XoUk=9yPTazDZsYHsfKrpPUygFk3UDGbCb3w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attached is v2, rebased over master. Only 0003 changed to remove a
declaration it had as context. The fixes are identical to v1.
Of the four, only 0001 has any practical server impact. If CreateThread
fails, every timer-based timeout in that process is silently disabled
for the rest of its lifetime. 0002 can hang pg_test_fsync. 0003 and
0004 are defensive fixes with no reachable in-core trigger.
I'll add this to the next commitfest.
Regards,
-- Sehrope Sarkuni
Founder & CEO | JackDB, Inc. | https://www.jackdb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0003-Fix-off-by-one-in-pgwin32_select-event-array.patch | application/x-patch | 1.3 KB |
| v2-0004-Do-not-treat-a-failed-wait-as-a-timeout-in-win32-.patch | application/x-patch | 1.3 KB |
| v2-0001-Fix-CreateThread-failure-check-in-win32-timer-cod.patch | application/x-patch | 1.1 KB |
| v2-0002-Fix-CreateThread-failure-check-in-pg_test_fsync.patch | application/x-patch | 999 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-08-29 20:10:45 | Re: remove_useless_joins vs. bug #19560 |
| Previous Message | Marina Polyakova | 2026-08-29 19:21:53 | Re: Function scan FDW pushdown |