Re: [PATCH] Support reading large objects with pg_read_all_data

On Tue, Feb 10, 2026 at 2:17 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> Hi Nitin, Your patch looks good to me except for some minor
> suggestions/questions.
>

Thanks Dilip for the feedback.

> 1. I think we can change the commit message slightly, and also removed
> the part which says added doc/test
> Suggestion:
> Support large object functions with pg_read_all_data
>

I updated the commit message according to this suggestion.

> Isn't it sufficient to just have second lo_get test i.e. SELECT
> lo_get(1002, 6, 5);, is there anything extra we are checking with the
> first test or is it just testing the same?
>
> Check other tests as well for loread(), seems there are multiple
> loread() tests that are testing the same functionality?
>

I have removed the redundant tests in the latest patch. The original
rationale was to test these functions with different arguments and
empty objects. But on reflection those are unrelated to the acl check.
So I'm only keeping one test per function.

Regards,
Nitin Motiani
Google