| From: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log message for GSS connection is missing once connection authorization is successful. |
| Date: | 2020-10-30 13:05:28 |
| Message-ID: | CAH503wB9CsJHA+YmKZe3Q--vnVu2B2T5ygW2hzAvp-5i0nzCkg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 30 Oct 2020 at 09:43, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Attached v3 patch has the change for the same.
>
>
Hi Vignesh,
+ appendStringInfo(&logmsg, "replication ");
+
+ appendStringInfo(&logmsg, "connection authorized: user=%s",
+ port->user_name);
+ if (!am_walsender)
+ appendStringInfo(&logmsg, " database=%s", port->database_name);
+
+ if (port->application_name != NULL)
+ appendStringInfo(&logmsg, " application_name=%s",
+ port->application_name);
+
Your approach breaks localization. You should use multiple errmsg.
+$node->append_conf('postgresql.conf', "logging_collector= 'on'");
+$node->append_conf('postgresql.conf', "log_connections= 'on'");
booleans don't need quotes.
--
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jimmy Angelakos | 2020-10-30 13:47:04 | [PATCH] Clarify wording for convalidated in pg_constraint. |
| Previous Message | vignesh C | 2020-10-30 12:52:35 | Re: Log message for GSS connection is missing once connection authorization is successful. |