Re: Persist injection points across server restarts

Hi Michael,

On Fri, May 30, 2025 at 5:01 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Thu, May 29, 2025 at 01:17:21PM +0530, Rahila Syed wrote:
> > After applying the v3-patches, I see failure like these:
> > macOS - Sonoma - Meson - Cirrus CI
> > <https://cirrus-ci.com/task/4589192849653760>
> > Windows - Server 2019, VS 2019 - Meson & ninja - Cirrus CI
> > <https://cirrus-ci.com/task/5715092756496384>
> > Linux - Debian Bookworm - Meson - Cirrus CI
> > <https://cirrus-ci.com/task/6629886430806016>
>
> These tasks complain about the following:
> [07:22:58.931] ../src/include/utils/injection_point.h:62:28: note:
> 'InjectionPointList' declared here [07:22:58.931] 62 | extern
> InjectionPointData *InjectionPointList(uint32 *num_points);
>
> The latest version of the patch (v3) posted on this thread includes
> the following:
> ./v3-0001-Add-InjectionPointList-to-retrieve-list-of-inject.patch:
> +extern List *InjectionPointList(void);
> ./v3-0001-Add-InjectionPointList-to-retrieve-list-of-inject.patch:
> +InjectionPointList(void)
> ./v3-0002-injection_points-Add-function-to-flush-injection-.patch:
> + inj_points = InjectionPointList();
>
> How is it possible for what you have applied to include changes that
> are not part of the patch set posted? Manual mistake on your side
> perhaps where versions of the patches have been mixed?
>
> The CF bot is green:
> https://commitfest.postgresql.org/patch/5731/

I apologize for the confusion; I mistakenly applied the wrong version of
the 0001 patch.
I can now confirm that the tests are passing on my end.

Thank you,
Rahila Syed