| From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: Enhancing Memory Context Statistics Reporting |
| Date: | 2026-02-24 11:57:17 |
| Message-ID: | CAH2L28sH3VoQDHE_kqgrmPMxUq7zdWzUWVB6kg-vu+c0_42MpA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Daniel,
Thank you for the review. All the changes suggested in the v52comments.diff
are incorporated in the attached patches.
+#Server should have thrown error
> +$node->psql(
> + 'postgres',
> + qq(select pg_get_process_memory_contexts($pid, true);),
> + stderr => \$psql_err);
>
> This test doesn't validate that the server actually errored does it?
> (There is
> no proposed fix in the attached.)
>
>
This has been fixed by adding a check for the error returned by the above
command.
While at it, I also added another crash test to the file, This is similar
to the existing
test for a client backend crash, but in this scenario, it crashes the
server process
instead.
Thank you,
Rahila Syed
| Attachment | Content-Type | Size |
|---|---|---|
| v53-0001-Add-function-to-report-memory-context-statistics.patch | application/octet-stream | 60.1 KB |
| v53-0002-Test-module-to-test-memory-context-reporting-wit.patch | application/octet-stream | 10.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-02-24 12:01:30 | Re: Flush some statistics within running transactions |
| Previous Message | Tatsuo Ishii | 2026-02-24 11:44:17 | Re: Row pattern recognition |