| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(at)vondra(dot)me>, Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Georgios <gkokolatos(at)protonmail(dot)com>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: index prefetching |
| Date: | 2026-03-29 19:52:08 |
| Message-ID: | CAH2-WzmpuPFPxV5nUQNs1skeROr69w_bDtvwr=ybCCrX9_GANw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 29, 2026 at 2:16 AM SATYANARAYANA NARLAPURAM
<satyanarlapuram(at)gmail(dot)com> wrote:
> I am still reviewing / understanding the patch, a couple quick comments based on my review.
>
> 1. Looks like off-by-one in the for loop in the patch v18-0015-WIP-aio-io_uring-Use-IO-size-not-IO-queue-to-tri.patch
You're right. Andres independently fixed this bug on our working
branch just yesterday.
> 2. NIT comment: _bt_endpoint return type changed to IndexScanBatch from bool in the patch v18-0005-Add-interfaces-that-enable-index-prefetching.patch.
> But the places it is returning false would be good to replace with NULL. Though false is treat as 0/NULL and no compiler errors, it improves the readability of the code.
I agree. This was a simple oversight, not a deliberate choice. It'll
be fixed in the next version.
Thanks
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Srinath Reddy Sadipiralla | 2026-03-29 20:16:36 | Re: Introduce XID age based replication slot invalidation |
| Previous Message | KAZAR Ayoub | 2026-03-29 19:46:52 | Re: Add pg_stat_vfdcache view for VFD cache statistics |