Re: WAL consistency check facility

From: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: WAL consistency check facility
Date: 2016-11-15 15:50:21
Message-ID: CAGz5QCJtNxBtzbopdoys__wm4bQX3=3mFXzsJYoOx5pYpNzYtw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Nov 15, 2016 at 7:23 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Nov 12, 2016 at 10:06 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> On 11/9/16 11:55 PM, Michael Paquier wrote:
>>> + <varlistentry id="guc-wal-consistency" xreflabel="wal_consistency">
>>> + <term><varname>wal_consistency</varname> (<type>string</type>)
>>> + <indexterm>
>>> + <primary><varname>wal_consistency</> configuration parameter</primary>
>>> + </indexterm>
>>> + </term>
>>> + <listitem>
>>> + <para>
>>> + This parameter is used to check the consistency of WAL records, i.e,
>>> + whether the WAL records are inserted and applied correctly. When
>>> + <varname>wal_consistency</varname> is enabled for a WAL record, it
>>> + stores a full-page image along with the record. When a full-page image
>>> + arrives during redo, it compares against the current page to check whether
>>> + both are consistent.
>>> + </para>
>>
>> Could we name this something like wal_consistency_checking?
>>
>> Otherwise it sounds like you use this to select the amount of
>> consistency in the WAL (similar to, say, wal_level).
>
> +1. I like that name.
I've modified the guc parameter name as wal_consistency_check (little
hesitant for a participle in suffix :) ). Also, updated the sgml and
variable name accordingly.
FYI, regression test will fail because of an inconsistency in brin
page. I've already submitted a patch for that. Following is the thread
for the same:
https://www.postgresql.org/message-id/flat/CAGz5QCJ%3D00UQjScSEFbV%3D0qO5ShTZB9WWz_Fm7%2BWd83zPs9Geg%40mail(dot)gmail(dot)com#CAGz5QCJ=00UQjScSEFbV=0qO5ShTZB9WWz_Fm7+Wd83zPs9Geg(at)mail(dot)gmail(dot)com
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
walconsistency_v15.patch application/x-download 48.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2016-11-15 15:53:41 jsonb_delete with arrays
Previous Message Tom Lane 2016-11-15 15:49:58 Re: postgres_fdw and defaults