Re: [PATCH] Improving Visibility of Temporary Table Usage

From: Mohamed ALi <moali(dot)pg(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Improving Visibility of Temporary Table Usage
Date: 2026-06-25 22:20:57
Message-ID: CAGnOmWrUv9=jx2CKmb_c8RxzCe3eVBofkow2qh3PO=-1b=wGtA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

Here is v2 of this patch, rebased on current HEAD (cae90d74796, as of
2026-06-25).

This rebase was triggered by the CFBot "Needs rebase" notification on CommitFest
entry #6835 [1]. The patch no longer applied cleanly due to upstream's async I/O
refactor

[1] https://commitfest.postgresql.org/patch/6835/

Changes from v1:
- Rebased onto PostgreSQL 19beta1 HEAD (1047 commits upstream since v1)
- Adapted bufmgr.c changes to work with the async I/O refactor introduced
upstream. pgstat_count_local_blk_hit() is now placed inside TrackBufferHit(),
the unified hit-tracking function added by the async I/O work.
pgstat_count_local_blk_read() is placed in StartReadBuffersImpl() next to
the existing local_blks_read update.
- Added missing !OidIsValid(dboid) || !IsUnderPostmaster guards to
pgstat_count_temp_table() for consistency with the other 4 counting
functions added in the same patch.
- Added !IsBootstrapProcessingMode() check in heap.c (defensive; bootstrap
cannot create temp tables, but makes intent explicit).

Patch attached.

--
Mohamed Ali

Attachment Content-Type Size
v2-0001-Add-temp-table-monitoring-columns-to-pg_stat_data.patch application/octet-stream 16.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-06-25 22:23:38 Re: Handle concurrent drop when doing whole database vacuum
Previous Message Peter Smith 2026-06-25 22:19:38 Re: Include sequences in publications created by pg_createsubscriber