| From: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com> |
|---|---|
| To: | Quan Zongliang <quanzongliang(at)yeah(dot)net> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Doc: add XML ID attributes to <varlistentry> tags for create_foreign_table, alter_foreign_table |
| Date: | 2025-11-13 02:46:44 |
| Message-ID: | CAGjGUAKghfjd3bBw4UWEZPOXzaSuyV7LeFV6+3YQtLUneVij8w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
> Since no more suggestions have been provided. And this is a very minor
> change. Although there are currently no other documents linked to these
> tags. This patch makes this document more complete and in line with
> conventions of other similar documents. So I changed it to "Ready for
> Committer"
Agree +1
Thanks
On Thu, Nov 13, 2025 at 10:20 AM Quan Zongliang <quanzongliang(at)yeah(dot)net>
wrote:
>
>
> On 9/22/25 9:27 AM, Quan Zongliang wrote:
> >
> >
> > On 9/19/25 11:08 AM, jian he wrote:
> >> hi.
> >>
> >> with commit like:
> >> https://git.postgresql.org/cgit/postgresql.git/commit/?
> >> id=78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5
> >>
> >> we can make a url link that points directly to a specific subsection
> >> of the document.
> >> for example:
> >> https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-
> >> CREATETABLE-PARMS-LIKE-OPT-COMMENTS
> >> will link to exactly the CREATE TABLE LIKE INCLUDING COMMENTS section.
> >>
> >> The attached patch adds XML ID attributes to <varlistentry> tags for
> >> create_foreign_table.sgml,
> >> and alter_foreign_table.sgml.
> >> While working on CREATE TABLE LIKE, I happened to find this issue.
> >> Maybe we can have a way to automate all <varlistentry>, but there are
> >> so many <varlistentry>.
> >
> > LGTM
> >
> > And I tested this patch on macOS Intel.
> >
> Since no more suggestions have been provided. And this is a very minor
> change. Although there are currently no other documents linked to these
> tags. This patch makes this document more complete and in line with
> conventions of other similar documents. So I changed it to "Ready for
> Committer"
>
> > --
> > Quan Zongliang
> >
> >
>
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-11-13 02:53:52 | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Previous Message | Manni Wood | 2025-11-13 02:40:35 | Re: Speed up COPY FROM text/CSV parsing using SIMD |